Entity Actions: Create button discernible text (fixes #20205)#20434
Merged
leekelleher merged 18 commits intoumbraco:mainfrom Oct 9, 2025
Merged
Entity Actions: Create button discernible text (fixes #20205)#20434leekelleher merged 18 commits intoumbraco:mainfrom
leekelleher merged 18 commits intoumbraco:mainfrom
Conversation
as `actions_viewActionsFor` already existed. Also made into a function, to support a fallback label.
Removed the need for a `getCreateAriaLabel()` method.
as the "umb-entity-actions-bundle" component handles this now.
# Conflicts: # src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-base/tree-item-element-base.ts
leekelleher
changed the title
leekelleher
approved these changes
Oct 9, 2025
Member
leekelleher
left a comment
leekelleher
left a comment
There was a problem hiding this comment.
Tested out, works well! 🚀
I made some code amends, to hopefully simplify the localization of the "Create item for" text.
leekelleher
added a commit
that referenced
this pull request
Oct 14, 2025
(#20458) * added hovering and focus border to RTE * fix main to OG * fix to main again * I'm going to cry * Missing localiztion feature, maybe UmbLitElement? * added localization controller to fetch localized version * localization successful for viewActionsFor and CreateFor * clean up button text * Changed label for content header to display proper name * clean up code * Included button labels for media section * clean code * Relocated localization keys, as `actions_viewActionsFor` already existed. Also made into a function, to support a fallback label. * Simplified the "Create for" label/localization Removed the need for a `getCreateAriaLabel()` method. * Removed the double-localizations (of `actions_viewActionsFor`) as the "umb-entity-actions-bundle" component handles this now. * imports tidy-up * Simplified localization key condition * switched to new localization key for other sections for new labeling * Bumped `@umbraco/playwright-testhelpers` 16.0.55 https://github.com/umbraco/Umbraco.Playwright.Testhelpers/releases/tag/release%2F16.0.55 --------- Co-authored-by: Oskar kruger <obk@umbraco.dk> Co-authored-by: leekelleher <leekelleher@gmail.com>
This was referenced Feb 23, 2026
This was referenced Mar 11, 2026
Closed
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added proper localization support for entity action buttons across different sections(content and media to start with), improving accessibility. The changes ensure consistent localization behavior for both "Create" and "View Actions" buttons along with support for a screen reader, addressing #20205 .
The current setup is made with implementing direct get methods in
packages/core/entity-action/entity-action.interface.ts, which seems like it might not be architecturally correct.Added localized key for English and German lang for testing.